Plain Text patch White Space damaged ?

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Plain Text patch White Space damaged ?

Gnome Evolution - General mailing list
With latest Evo, 3.38.1, it seems like all patches I receive are WS damaged w.r.t TAB, appears
to replace with 8 SPACEes instead.

 Jocke
_______________________________________________
evolution-list mailing list
[hidden email]
To change your list options or unsubscribe, visit ...
https://mail.gnome.org/mailman/listinfo/evolution-list
Reply | Threaded
Open this post in threaded view
|

Re: Plain Text patch White Space damaged ?

Gnome Evolution - General mailing list
On Tue, 2020-11-03 at 12:09 +0000, Joakim Tjernlund via evolution-list
wrote:
> With latest Evo, 3.38.1, it seems like all patches I receive are WS
> damaged w.r.t TAB, appears to replace with 8 SPACEes instead.

What makes you think that the message had tabs instead of spaces?
Which webkit version is involved?
Where to find a test case?

andre
--
Andre Klapper  |  [hidden email]
https://blogs.gnome.org/aklapper/


_______________________________________________
evolution-list mailing list
[hidden email]
To change your list options or unsubscribe, visit ...
https://mail.gnome.org/mailman/listinfo/evolution-list
Reply | Threaded
Open this post in threaded view
|

Re: Plain Text patch White Space damaged ?

Gnome Evolution - General mailing list
On Tue, 2020-11-03 at 13:19 +0100, Andre Klapper via evolution-list wrote:
>
>
> On Tue, 2020-11-03 at 12:09 +0000, Joakim Tjernlund via evolution-list
> wrote:
> > With latest Evo, 3.38.1, it seems like all patches I receive are WS
> > damaged w.r.t TAB, appears to replace with 8 SPACEes instead.
>
> What makes you think that the message had tabs instead of spaces?

It is a Linux PATCH and Linux uses TABS for indent.
I then check other patches I had I my Inbox and they were the same, no TABs

> Which webkit version is involved?

webkit-gtk-2.28.4

> Where to find a test case?
I can forward the patch I tried:

commit 2fb541c862c9 ("net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc")

When the above upstream commit is backported to stable kernel,
one assignment is missing, which causes two problems reported
by Joakim and Vishwanath, see [1] and [2].

So add the assignment back to fix it.

1.
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.spinics.net%2Flists%2Fnetdev%2Fmsg693916.html&data=04%7C01%7CJoakim.Tjernlund%40infinera.com%7C7bc873a1d44d431f062008d87fa8a625%7C285643de5f5b4b03a1530ae2dc8aaf77%7C1%7C0%7C637399709608572537%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=L%2BLZL5de2DysJxtrPLdHYzoc3A6Tkero7P67JmIn4BM%3D&reserved=0
2.
https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.spinics.net%2Flists%2Fnetdev%2Fmsg695131.html&data=04%7C01%7CJoakim.Tjernlund%40infinera.com%7C7bc873a1d44d431f062008d87fa8a625%7C285643de5f5b4b03a1530ae2dc8aaf77%7C1%7C0%7C637399709608572537%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=prOeVIM6IZsdxw5Hr1SZGqziljq5JT214ltqcpyYyLk%3D&reserved=0

Fixes: 749cc0b0c7f3 ("net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc")
Signed-off-by: Yunsheng Lin <[hidden email]>
---
 net/sched/sch_generic.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/sched/sch_generic.c b/net/sched/sch_generic.c
index 0e275e1..6e6147a 100644
--- a/net/sched/sch_generic.c
+++ b/net/sched/sch_generic.c
@@ -1127,10 +1127,13 @@ static void dev_deactivate_queue(struct net_device *dev,
                                 void *_qdisc_default)
 {
        struct Qdisc *qdisc = rtnl_dereference(dev_queue->qdisc);
+       struct Qdisc *qdisc_default = _qdisc_default;

        if (qdisc) {
                if (!(qdisc->flags & TCQ_F_BUILTIN))
                        set_bit(__QDISC_STATE_DEACTIVATED, &qdisc->state);
+
+               rcu_assign_pointer(dev_queue->qdisc, qdisc_default);
        }
 }

--
2.7.4

_______________________________________________
evolution-list mailing list
[hidden email]
To change your list options or unsubscribe, visit ...
https://mail.gnome.org/mailman/listinfo/evolution-list
Reply | Threaded
Open this post in threaded view
|

Re: Plain Text patch White Space damaged ?

Gnome Evolution - General mailing list
On Tue, 2020-11-03 at 12:32 +0000, Joakim Tjernlund via evolution-list wrote:

>
> On Tue, 2020-11-03 at 13:19 +0100, Andre Klapper via evolution-list wrote:
> >
> >
> > On Tue, 2020-11-03 at 12:09 +0000, Joakim Tjernlund via evolution-list
> > wrote:
> > > With latest Evo, 3.38.1, it seems like all patches I receive are WS
> > > damaged w.r.t TAB, appears to replace with 8 SPACEes instead.
> >
> > What makes you think that the message had tabs instead of spaces?
>
> It is a Linux PATCH and Linux uses TABS for indent.
> I then check other patches I had I my Inbox and they were the same, no TABs
>
>

I also saved the mail as mbox and had the same result, no TABs
_______________________________________________
evolution-list mailing list
[hidden email]
To change your list options or unsubscribe, visit ...
https://mail.gnome.org/mailman/listinfo/evolution-list
Reply | Threaded
Open this post in threaded view
|

Re: Plain Text patch White Space damaged ?

Gnome Evolution - General mailing list
On Tue, 2020-11-03 at 13:34 +0100, Joakim Tjernlund via evolution-list
wrote:
> I also saved the mail as mbox and had the same result, no TABs

        Hi,
that means the source message doesn't have tabs there. When I open your
second link [2] (I've no idea what the first link was about, because
there didn't seem to be any tab used, even I could overlook it there),
then even the browser shows the whitespace (which look like a good
candidate for a tab) as spaces. Try to select it.

Nonetheless, I tried it here and I see that the .mbox file does use
tabs as expected, both in a sent message and in a Draft message, it's
the UI part of the Evolution to present tabs as spaces in the
text/plain version of the message (it does not do that for the HTML
version). Thus it looks like Evolution misinterprets tabs when
converting plain text into an HTML form.

Would you mind to file a bug about that, please? [1] It can be in the
evolution-data-server, because the code to convert plain text into the
HTML is there.

        Thanks and bye,
        Milan

P.S.: by the way, the indentation I use on hi & bye is also a tab

[1] https://gitlab.gnome.org/GNOME/evolution-data-server/new
[2] https://www.spinics.net/lists/netdev/msg695131.html

_______________________________________________
evolution-list mailing list
[hidden email]
To change your list options or unsubscribe, visit ...
https://mail.gnome.org/mailman/listinfo/evolution-list
Reply | Threaded
Open this post in threaded view
|

Re: Plain Text patch White Space damaged ?

Gnome Evolution - General mailing list
On Tue, 2020-11-03 at 14:01 +0100, Milan Crha via evolution-list wrote:
>
> On Tue, 2020-11-03 at 13:34 +0100, Joakim Tjernlund via evolution-list
> wrote:
> > I also saved the mail as mbox and had the same result, no TABs
>
>         Hi,
> that means the source message doesn't have tabs there. When I open your

I does have TABs, when I google the same patch I can find with TABs

> second link [2] (I've no idea what the first link was about, because
> there didn't seem to be any tab used, even I could overlook it there),
> then even the browser shows the whitespace (which look like a good
> candidate for a tab) as spaces. Try to select it.

Never mind the links, these were just part of the commit msg. Look at the
diff in the end. There are no TABs in there.

>
> Nonetheless, I tried it here and I see that the .mbox file does use
> tabs as expected, both in a sent message and in a Draft message, it's
> the UI part of the Evolution to present tabs as spaces in the
> text/plain version of the message (it does not do that for the HTML
> version). Thus it looks like Evolution misinterprets tabs when
> converting plain text into an HTML form.

hmm, my mbox did not have TABs in it, I am sure.
I wonder if MS(O365) has started to filter out TABs now?

>
> Would you mind to file a bug about that, please? [1] It can be in the
> evolution-data-server, because the code to convert plain text into the
> HTML is there.
>
>         Thanks and bye,
>         Milan
>
> P.S.: by the way, the indentation I use on hi & bye is also a tab
>
> [1] https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.gnome.org%2FGNOME%2Fevolution-data-server%2Fnew&amp;data=04%7C01%7Cjoakim.tjernlund%40infinera.com%7C91f1fdd5beb346a1000608d87ff96765%7C285643de5f5b4b03a1530ae2dc8aaf77%7C1%7C0%7C637400056447463037%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=ux2g9tsJxr75wgjSC8cpgPI9OFUM1W8p2mTWeL4guSA%3D&amp;reserved=0
> [2] https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.spinics.net%2Flists%2Fnetdev%2Fmsg695131.html&amp;data=04%7C01%7Cjoakim.tjernlund%40infinera.com%7C91f1fdd5beb346a1000608d87ff96765%7C285643de5f5b4b03a1530ae2dc8aaf77%7C1%7C0%7C637400056447463037%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=8OGTu%2B%2BlTrqfI6jOYBSF7KPOxAvKvVOko53eOUBYiTo%3D&amp;reserved=0
>
> _______________________________________________
> evolution-list mailing list
> [hidden email]
> To change your list options or unsubscribe, visit ...
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.gnome.org%2Fmailman%2Flistinfo%2Fevolution-list&amp;data=04%7C01%7Cjoakim.tjernlund%40infinera.com%7C91f1fdd5beb346a1000608d87ff96765%7C285643de5f5b4b03a1530ae2dc8aaf77%7C1%7C0%7C637400056447473031%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=jkNCdbXzZN8hB6fdTJB1FOlYXG7PElI2UY9TZLelepQ%3D&amp;reserved=0

_______________________________________________
evolution-list mailing list
[hidden email]
To change your list options or unsubscribe, visit ...
https://mail.gnome.org/mailman/listinfo/evolution-list
Reply | Threaded
Open this post in threaded view
|

Re: Plain Text patch White Space damaged ?

Gnome Evolution - General mailing list
On Tue, 2020-11-03 at 14:16 +0100, Joakim Tjernlund wrote:
> hmm, my mbox did not have TABs in it, I am sure.
> I wonder if MS(O365) has started to filter out TABs now?

        Hi,
that's an interesting idea, because your message doesn't have tabs,
while the message in the list archive do have it (that I sent and which
I received back through the list; it can be seen in [1]).

Either it's evolution-ews or the Exchange server changing the tabs in
the message content. It doesn't change anything on the fact that the
tabs are replaced by spaces in the message preview when the message
source is a plain text.
        Bye,
        Milan

P.S.: Reply To List (Ctrl+L) works better for me on this list

[1] https://mail.gnome.org/archives/evolution-list/2020-November.txt.gz

_______________________________________________
evolution-list mailing list
[hidden email]
To change your list options or unsubscribe, visit ...
https://mail.gnome.org/mailman/listinfo/evolution-list
Reply | Threaded
Open this post in threaded view
|

Re: Plain Text patch White Space damaged ?

Gnome Evolution - General mailing list
In reply to this post by Gnome Evolution - General mailing list
On Tue, 2020-11-03 at 14:01 +0100, Milan Crha via evolution-list wrote:

>
> On Tue, 2020-11-03 at 13:34 +0100, Joakim Tjernlund via evolution-list
> wrote:
> > I also saved the mail as mbox and had the same result, no TABs
>
>         Hi,
> that means the source message doesn't have tabs there. When I open your
> second link [2] (I've no idea what the first link was about, because
> there didn't seem to be any tab used, even I could overlook it there),
> then even the browser shows the whitespace (which look like a good
> candidate for a tab) as spaces. Try to select it.
>
> Nonetheless, I tried it here and I see that the .mbox file does use
> tabs as expected, both in a sent message and in a Draft message, it's
> the UI part of the Evolution to present tabs as spaces in the
> text/plain version of the message (it does not do that for the HTML
> version). Thus it looks like Evolution misinterprets tabs when
> converting plain text into an HTML form.

https://gitlab.gnome.org/GNOME/evolution/-/issues/1206

>
> Would you mind to file a bug about that, please? [1] It can be in the
> evolution-data-server, because the code to convert plain text into the
> HTML is there.

_______________________________________________
evolution-list mailing list
[hidden email]
To change your list options or unsubscribe, visit ...
https://mail.gnome.org/mailman/listinfo/evolution-list